x86: Removes ioapic rerouting test
authorBarret Rhoden <brho@cs.berkeley.edu>
Fri, 20 Jun 2014 19:56:59 +0000 (12:56 -0700)
committerBarret Rhoden <brho@cs.berkeley.edu>
Fri, 20 Jun 2014 20:01:27 +0000 (13:01 -0700)
It doesn't work and just spews warnings, and no one is fixing it.  It
was originally meant to be watched by a human too.

Feel free to add a real IRQ routing test that's more than a printk in an
IRQ handler (which is what I've used in the past).

kern/src/ktest/Kconfig.postboot
kern/src/ktest/pb_ktests.c

index 205647f..683d694 100644 (file)
@@ -19,13 +19,6 @@ config TEST_pic_reception
     help
         Run the pic_reception
 
-config TEST_ioapic_pit_reroute 
-    depends on PB_KTESTS && X86
-    bool "IOAPIC PIT reroute test"
-    default n
-    help
-        Run the ioapic_pit_reroute test
-
 config TEST_lapic_status_bit
     depends on PB_KTESTS && X86
     bool "LAPIC status bit test"
index e7b165f..c8f5daa 100644 (file)
@@ -112,32 +112,6 @@ bool test_pic_reception(void)
        return true;
 }
 
-// TODO: Add assertions.
-bool test_ioapic_pit_reroute(void) 
-{
-       register_irq(IdtPIC + IrqCLOCK, test_hello_world_handler, NULL,
-                    MKBUS(BusISA, 0, 0, 0));
-#ifdef CONFIG_ENABLE_MPTABLES
-#warning "not routing the irq"
-       //ioapic_route_irq(0, 3);       
-#endif
-
-       cprintf("Starting pit on core 3....\n");
-       udelay(3000000);
-       pit_set_timer(0xFFFE,TIMER_RATEGEN); // totally arbitrary time
-       
-       udelay(3000000);
-#ifdef CONFIG_ENABLE_MPTABLES
-#warning "NOT unrouting the irq"
-       //ioapic_unroute_irq(0);
-#endif
-       udelay(300000);
-       cprintf("Masked pit. Waiting before return...\n");
-       udelay(3000000);
-
-       return true;
-}
-
 #endif // CONFIG_X86
 
 // TODO: Add assertions. Possibly the way to go is to extract relevant info 
@@ -2023,7 +1997,6 @@ static struct ktest ktests[] = {
 #ifdef CONFIG_X86
        KTEST_REG(ipi_sending,        CONFIG_TEST_ipi_sending),
        KTEST_REG(pic_reception,      CONFIG_TEST_pic_reception),
-       KTEST_REG(ioapic_pit_reroute, CONFIG_TEST_ioapic_status_bit),
        KTEST_REG(lapic_status_bit,   CONFIG_TEST_lapic_status_bit),
        KTEST_REG(pit,                CONFIG_TEST_pit),
        KTEST_REG(circ_buffer,        CONFIG_TEST_circ_buffer),